fix(cli): project root resolution #5712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Feb 12, 2024 4:51 PM (UTC)
|
juice49
force-pushed
the
fix/sdx-1073-cli-project-root-resolution
branch
from
2c4990c
to
45a14e1
Compare
juice49
requested review from
binoy14 and
a team
and removed request for
a team
rexxars
pushed a commit
that referenced
this pull request
Feb 14, 2024
* fix(cli): project root resolution * test(cli): test basic command can be run from Studio subdirectory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CLI is intended to automatically resolve the project root if it's used inside the subdirectory of a Studio project. This behaviour has been broken for v3, because the resolution code mistakenly searches for
studio.config.{ts,js}files, rather thansanity.config.{ts,js}. Therefore, it never finds the project root.This was discovered and discussed in #5684.
What to review
Testing
helpcommand can be executed inside Studio project subdirectories, and that the warning is printed.Notes for release
Fixed a bug that prevented the CLI being used inside Studio project subdirectories.