Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): update help copy for CLI commands #5687

Merged
merged 4 commits into from
Feb 14, 2024
Merged

chore(cli): update help copy for CLI commands #5687

merged 4 commits into from
Feb 14, 2024

Conversation

binoy14
Copy link
Contributor

@binoy14 binoy14 commented Feb 6, 2024

Description

Updates the help copy for cli commands

What to review

Copy makes sense

Testing

yarn build && npx sanity help

Notes for release

N/A

@binoy14 binoy14 requested a review from a team as a code owner February 6, 2024 19:54
@binoy14 binoy14 requested review from jtpetty and removed request for a team February 6, 2024 19:54
@vercel Vercel
Copy link

vercel bot commented Feb 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 8, 2024 1:31am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 1:31am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2024 1:31am

@binoy14 binoy14 requested review from runeb and kmelve February 6, 2024 19:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024 •
edited
Loading

Component Testing Report Updated Feb 8, 2024 1:35 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 37s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 14s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 19s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 20s 9 0 0

jtpetty
jtpetty approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@jtpetty jtpetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binoy14 binoy14 requested a review from runeb February 7, 2024 19:30
runeb
runeb requested changes Feb 7, 2024
View reviewed changes
Copy link
Member

@runeb runeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished adding suggestions

packages/@sanity/cli/src/commands/codemod/codemodCommand.ts Outdated Show resolved Hide resolved
packages/@sanity/cli/src/commands/debug/debugCommand.ts Outdated Show resolved Hide resolved
packages/@sanity/cli/src/commands/docs/docsCommand.ts Outdated Show resolved Hide resolved
packages/@sanity/cli/src/commands/init/initCommand.ts Outdated Show resolved Hide resolved
packages/@sanity/cli/src/commands/install/installCommand.ts Outdated Show resolved Hide resolved
packages/sanity/src/_internal/cli/commands/graphql/graphqlGroup.ts Outdated Show resolved Hide resolved
packages/sanity/src/_internal/cli/commands/hook/hookGroup.ts Outdated Show resolved Hide resolved
packages/sanity/src/_internal/cli/commands/migration/migrationGroup.ts Outdated Show resolved Hide resolved
packages/sanity/src/_internal/cli/commands/preview/previewCommand.ts Outdated Show resolved Hide resolved
packages/sanity/src/_internal/cli/commands/start/startCommand.ts Outdated Show resolved Hide resolved
@binoy14 binoy14 requested a review from runeb February 8, 2024 01:29
@binoy14 binoy14 merged commit b17a5e4 into next Feb 14, 2024
40 checks passed
@binoy14 binoy14 deleted the chore/update-cli-help branch February 14, 2024 14:49
rexxars pushed a commit that referenced this pull request Feb 14, 2024
@binoy14 @runeb @rexxars
chore(cli): update help copy for CLI commands (#5687)
12fb96b 
* chore(cli): update help copy for CLI commands

* chore(cli): update copy for manage command

* chore(cli): update CLI commands copy

Co-authored-by: Rune Botten <[email protected]>

* chore(cli): fix prettier issues

---------

Co-authored-by: Rune Botten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpetty jtpetty jtpetty approved these changes

@kmelve kmelve Awaiting requested review from kmelve

@runeb runeb Awaiting requested review from runeb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binoy14 @runeb @jtpetty