fix(form): preserve intrinsic block size of field labels #5639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Feb 1, 2024 11:50 AM (UTC)
|
juice49
force-pushed
the
fix/sdx-982-boolean-field-alignment
branch
from
e866a90 to
9ce1eeb
Compare
juice49
requested review from
bjoerge,
a team and
jtpetty
and removed request for
a team
juice49
force-pushed
the
fix/sdx-982-boolean-field-alignment
branch
from
9ce1eeb to
5918dd7
Compare
|
@juice49 - any idea why the failed check? |
|
@jtpetty Which failure? I believe they're all passing for the latest commit, but I might be missing something! Update: Oh! Are you referring to this one? |
|
@jtpetty This appears to be an issue with flaky tests. All passing on re-run 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch improves vertical alignment in boolean fields. It uses CSS size containment to prevent the block size of elements appended to field labels (such as the deprecated field badge) affecting the intrinsic block size of the label.
Closes #5579.
Before (non-deprecated booleans)
After (non-deprecated booleans)
Before (deprecated booleans)
After (deprecated booleans)
What to review
Testing
/test/structure/input-standard;booleansTest).Notes for release
Improve vertical alignment of boolean fields.