-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve asset export retrying #5563
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Report@sanity/diff
@sanity/block-tools
@sanity/types
sanity/desk
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/util/legacyDateFormat
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/schema
sanity/structure
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
sanity/_internalBrowser
@sanity/util/content
sanity
|
Component Testing Report Updated Jan 26, 2024 12:14 PM (UTC)
|
1139430
to
daafdad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I have tried this change locally, this seem to be working as expected, as seen in debug mode. This approach will make CLI export resilient against flaky server-side and network errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* fix: hoist retry mechanism when downloading assets * feat: improve error handling in downloadAsset * feat: retry more failure cases in downloadAsset * feat: rety asset downloading 10 times
Description
We are experiencing that our export assets endpoints hangs up the connections, and for some reason the CLI is trying to reuse the dead connection. This PR adds more retry mechanisms to download assets.
What to review
Testing
Notes for release