fix(core): fix type issues and add tests for datetime input #5558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Report@sanity/diff
@sanity/block-tools
@sanity/types
sanity/desk
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/util/legacyDateFormat
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/schema
sanity/structure
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
sanity/_internalBrowser
@sanity/util/content
sanity
|
|
Component Testing Report Updated Jan 24, 2024 6:14 PM (UTC)
|
jtpetty
pushed a commit
that referenced
this pull request
Jan 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
* bug(i18n): fix issue with date formatting in validation message * bug(i18n): better fix with tests * bug(i18n): fix date drift on validation and date validator tests * fix(core): fix type issues and add tests for datetime input (#5558) * fix(core): update date validator tests to use strings * chore(core): use centrally defined date constants --------- Co-authored-by: Binoy Patel <[email protected]>
ricokahler
pushed a commit
that referenced
this pull request
Jan 26, 2024
* bug(i18n): fix issue with date formatting in validation message * bug(i18n): better fix with tests * bug(i18n): fix date drift on validation and date validator tests * fix(core): fix type issues and add tests for datetime input (#5558) * fix(core): update date validator tests to use strings * chore(core): use centrally defined date constants --------- Co-authored-by: Binoy Patel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What to review
Testing
Notes for release