chore(eslint): add rules to enforce consistent type imports and deterministic import orders

[bjoerge]

Description

Enforcing consistent type imports and deterministic (ordered by type + alphabetical) import orders will help us reduce time spent on resolving diffs conflicts & performing code reviews

What to review

This PR consists of discrete commits that could be reviewed individually:

• Removes usage of import React from 'react' (thanks to @binoy14 for chore: removes React imports due to new jsx transform #5522), and enables jsx: 'automatic' with esbuild-register in dev server
• upgrades various eslint dependencies to latest
• adds rules to enforce consistent imports and type imports
• runs eslint --autofix on all sourcefiles (this is the big one, and can be skipped)
• a handful commits that manually fixes some issues that surfaced after rewriting import statements

Note: looks like the eslint CI workflow is being run with config from next, so it currently fails here, but it passes locally, and will likely pass once we merge this branch.

I have tested quite extensively and not found any issues beyon the ones already fixed here.

Testing

Notes for release

n/a

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
performance-studio	✅ Ready (Inspect)	Visit Preview		Feb 9, 2024 1:12pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 9, 2024 1:12pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Feb 9, 2024 1:12pm

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@eslint-community/[email protected]	None	0	431 kB	eslint-community-bot
npm/@types/[email protected]	None	0	23.2 kB	types
npm/@typescript-eslint/[email protected]	Transitive: environment, eval, filesystem, shell, unsafe	+119	56.9 MB	jameshenry
npm/@typescript-eslint/[email protected]	Transitive: environment, eval, filesystem, shell, unsafe	+114	53.8 MB	jameshenry
npm/@typescript-eslint/[email protected]	None	+2	787 kB	jameshenry
npm/@typescript-eslint/[email protected]	None	0	156 kB	jameshenry
npm/@typescript-eslint/[email protected]	Transitive: environment, filesystem	+33	42.8 MB	jameshenry
npm/@typescript-eslint/[email protected]	None	+1	175 kB	jameshenry
npm/[email protected]	Transitive: environment, eval, filesystem, shell, unsafe	+91	10.6 MB	lydell
npm/[email protected]	Transitive: environment, eval, filesystem, shell, unsafe	+106	11.2 MB	javierbrea
npm/[email protected]	filesystem, unsafe Transitive: environment, eval, shell	+168	16.8 MB	ljharb
npm/[email protected]	Transitive: environment, eval, filesystem, shell, unsafe	+98	19.3 MB	jounqin
npm/[email protected]	Transitive: environment, eval, filesystem, shell, unsafe	+91	10.6 MB	lydell
npm/[email protected]	Transitive: environment, eval, filesystem, shell, unsafe	+121	56.9 MB	sweepline
npm/[email protected]	environment, filesystem Transitive: eval, shell, unsafe	+90	10.6 MB	eslintbot
npm/[email protected]	environment, filesystem, unsafe	+4	355 kB	jonaskello

🚮 Removed packages: npm/@eslint-community/[email protected], npm/@sanity/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Feb 9, 2024 1:15 PM (UTC)

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	32s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	6s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	13s	3	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	13s	4	2	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	13s	6	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	33s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	19s	9	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	59s	18	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	15s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	20s	9	0	0

[binoy14]

Hard to review the files, github just crashes and even typing this there is so much lag 😅 but all checks passes so trusting it works. Maybe we can do a canary bump and check in couple studios to be sure.

Also thanks a lot for getting it across the line!