Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename "schemas" to the more correct plural "schemaTypes" #5513

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

SimeonGriggs
Copy link
Contributor

@SimeonGriggs SimeonGriggs commented Jan 17, 2024

Description

A Studio can have many "schemas", in that it can have multiple workspaces.

But a collection of schema types – for example a post, author, category is not best described by the word "schemas" but that is the name for files and folder structures in new Sanity Studio projects.

This PR has renamed most instances of "schemas" to "schemaTypes" / "schema types" where it is most appropriate.

What to review

That new Studio installs of the various templates still work! Admittedly, I don't fully know how to test the functional impact of these proposed changes. But the impact of them will be more correctness in our training materials.

Notes for release

Corrected the default folder name for schema types

@SimeonGriggs SimeonGriggs requested a review from a team January 17, 2024 13:13
@SimeonGriggs SimeonGriggs requested a review from a team as a code owner January 17, 2024 13:13
@SimeonGriggs SimeonGriggs requested review from robinpyon and ricokahler and removed request for a team January 17, 2024 13:13
Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Jan 19, 2024 10:13pm
studio-workshop 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 10:13pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 10:13pm

Copy link
Contributor

github-actions bot commented Jan 17, 2024

Package Documentation Change
sanity -3%
Full Report
@sanity/diff
This branch Next branch
13 documented 13 documented
16 not documented 16 not documented
@sanity/block-tools
This branch Next branch
4 documented 4 documented
9 not documented 9 not documented
@sanity/types
This branch Next branch
55 documented 55 documented
234 not documented 234 not documented
sanity/desk
This branch Next branch
84 documented 84 documented
64 not documented 64 not documented
@sanity/portable-text-editor
This branch Next branch
21 documented 21 documented
44 not documented 44 not documented
@sanity/mutator
This branch Next branch
7 documented 7 documented
4 not documented 4 not documented
@sanity/cli
This branch Next branch
1 documented 1 documented
31 not documented 31 not documented
@sanity/schema/_internal
This branch Next branch
0 documented 0 documented
12 not documented 12 not documented
@sanity/util/paths
This branch Next branch
1 documented 1 documented
15 not documented 15 not documented
sanity/router
This branch Next branch
17 documented 17 documented
26 not documented 26 not documented
@sanity/util/legacyDateFormat
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/schema
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
sanity/structure
This branch Next branch
2 documented 2 documented
6 not documented 6 not documented
sanity/cli
This branch Next branch
2 documented 2 documented
0 not documented 0 not documented
@sanity/vision
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/util/fs
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
sanity/_internal
This branch Next branch
0 documented 0 documented
1 not documented 1 not documented
sanity/_internalBrowser
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/util/content
This branch Next branch
1 documented 1 documented
5 not documented 5 not documented
sanity
This branch Next branch
177 documented 183 documented
843 not documented 846 not documented

Copy link
Contributor

github-actions bot commented Jan 17, 2024

Component Testing Report Updated Jan 19, 2024 10:15 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 18s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 7s 3 0 0

Copy link
Contributor

@ricokahler ricokahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of any reasons why this would break anything and I agree with the semantics. Love it!

@SimeonGriggs
Copy link
Contributor Author

I've tested creating new Studios locally with these changes and they boot up fine.

@SimeonGriggs SimeonGriggs added this pull request to the merge queue Feb 9, 2024
Merged via the queue into next with commit 2eaffd3 Feb 9, 2024
40 checks passed
@SimeonGriggs SimeonGriggs deleted the chore/schema-types branch February 9, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants