Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/pt input #5472

Closed
wants to merge 18 commits into from
Closed

Refactor/pt input #5472

wants to merge 18 commits into from

Conversation

skogsmaskin
Copy link
Member

Description

What to review

Notes for release

@vercel Vercel
Copy link

vercel bot commented Jan 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 15, 2024 3:33pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 3:33pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 3:33pm

@skogsmaskin @robinpyon
feat(form/inputs): control PT-input fullscreen from props
f1ce6bc
@skogsmaskin @robinpyon
fix(form/inputs): remove z-index causing issues
2679972 
I don't think these are needed anymore? They mess up inline rendered forms for objects
@skogsmaskin @robinpyon
fix(form/inputs): don't manipulate selection css here
1e6c800 
This will make it impossible to select something in inline rendered inputs. As far as I can see we no longer need this rule.
@skogsmaskin @robinpyon
feat(form/inputs): add prop to hide the toolbar in PT-input
02a8a3c
@skogsmaskin @robinpyon
feat(portable-text-editor): make it possible to drag and drop regular…
25abdad 
… text blocks
@skogsmaskin @robinpyon
feat(form/inputs): PortableTextInput can now use a editor ref
69edfd2 
This will allow us to control the PortableTextEditor from the outside.
@skogsmaskin @robinpyon
feat(portable-text-editor): support for range decorators
871da6a 
This will add support for decorating selections inside the Portable Text Editor with custom components.
This can be used for search highlighting, validation etc.
@skogsmaskin @robinpyon
feat(form/hooks): make useCursorElement available in core
197705a 
This is needed elsewhere too
@skogsmaskin @robinpyon
feat(form/inputs): add onEditorChange prop to PT-input
3478763 
This will allow consumers to hook into editor changes by supplying their own handler to the PortableTextInput props
@skogsmaskin @robinpyon
feat(form/inputs): support rendering PTE Editable through PortableTex…
b88394d 
…tInput
@skogsmaskin @robinpyon
fix(portable-text-editor): fix error message copy
31ef4a9
@skogsmaskin @robinpyon
feat(portable-text-editor): getFragment function
cb6c6c5
@skogsmaskin @robinpyon
fix(form/inputs): render with props, but without defaultRender
db0a83e 
defaultRender is not part of the PortableTextEditor's Editable props
@skogsmaskin @robinpyon
feat(form/inputs): control active state through props for PT-input
60fe5ac
@skogsmaskin @robinpyon
feat(form/hooks): track scrolling for useCursorElement
a337baf
@skogsmaskin @robinpyon
feat(portable-text-editor): New editable prop: isDraggableType?
a7af2a8 
This will allow the Editable consumer to decide which types are draggable
@skogsmaskin @robinpyon
feat(portable-text-editor): remove any arbitrary properties from a sp…
4a5ff45 
…lit block

There could be some arbritary properties on the value, make sure that these are not carried over to the new split block.
@github-actions GitHub Actions
Copy link
Contributor

Package Documentation Change
@sanity/portable-text-editor +5%
sanity +1%
Full Report
@sanity/portable-text-editor
This branch Next branch
22 documented 21 documented
45 not documented 44 not documented
sanity
This branch Next branch
179 documented 178 documented
841 not documented 849 not documented
@sanity/migrate
This branch Next branch
14 documented 14 documented
78 not documented 62 not documented
@sanity/diff
This branch Next branch
13 documented 13 documented
16 not documented 16 not documented
@sanity/block-tools
This branch Next branch
4 documented 4 documented
9 not documented 9 not documented
@sanity/types
This branch Next branch
55 documented 55 documented
233 not documented 239 not documented
sanity/desk
This branch Next branch
84 documented 84 documented
64 not documented 64 not documented
@sanity/mutator
This branch Next branch
7 documented 7 documented
3 not documented 4 not documented
@sanity/cli
This branch Next branch
1 documented 1 documented
31 not documented 31 not documented
sanity/structure
This branch Next branch
2 documented 2 documented
8 not documented 8 not documented
@sanity/util/concurrency-limiter
This branch Next branch
1 documented 1 documented
0 not documented 0 not documented
@sanity/util/legacyDateFormat
This branch Next branch
0 documented 0 documented
4 not documented 5 not documented
@sanity/schema/_internal
This branch Next branch
0 documented 0 documented
12 not documented 12 not documented
@sanity/util/paths
This branch Next branch
1 documented 1 documented
15 not documented 15 not documented
sanity/router
This branch Next branch
17 documented 17 documented
26 not documented 26 not documented
@sanity/schema
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
sanity/cli
This branch Next branch
2 documented 2 documented
0 not documented 0 not documented
@sanity/vision
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/util/fs
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
sanity/_internal
This branch Next branch
0 documented 0 documented
1 not documented 1 not documented
@sanity/util/client
This branch Next branch
1 documented 1 documented
0 not documented 0 not documented
@sanity/util/createSafeJsonParser
This branch Next branch
1 documented 1 documented
0 not documented 0 not documented
sanity/_internalBrowser
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/util/content
This branch Next branch
1 documented 1 documented
5 not documented 5 not documented

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024 •
edited
Loading

Component Testing Report Updated Feb 15, 2024 3:37 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 18s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 59s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@rexxars
Copy link
Member

rexxars commented Aug 13, 2024

@skogsmaskin @christianhg Is this PR/branch still needed?

@skogsmaskin
Copy link
Member Author

I think @robinpyon has pulled in most of these changes based off this branch. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skogsmaskin @rexxars @robinpyon