refactor(portable-text-editor): remove obsolete code #5393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After #5136 this code is no longer needed as the MutationObserver actually does what it is supposed to. There is also a bug in this code that doesn't take into account that the particular editor is focused and selected before removing all the DOM selection ranges.
skogsmaskin
requested review from
a team and
ninaandal
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Report@sanity/diff
@sanity/block-tools
@sanity/types
sanity/desk
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/content
sanity
|
snorrees
approved these changes
Dec 19, 2023
|
Component Testing Report Updated Dec 19, 2023 1:56 PM (UTC)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #5136 this code is no longer needed as the MutationObserver does what it is supposed to and verifies the selection properly.
There is also a bug in this removed code that doesn't take into account that the particular editor is focused and selected before removing all the DOM selection ranges, which has side effects in documents with several editors.
Notes for release