Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): fix confirm delete dialog #5139

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

ricokahler
Copy link
Contributor

Description

A follow up from #5114 so that these components use the context prop instead of passing it through values

Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Nov 7, 2023 0:37am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 0:37am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Nov 7, 2023 0:37am

@ricokahler ricokahler changed the title Feat/i18n fix confirm delete feat(i18n): fix confirm delete Nov 7, 2023
@ricokahler ricokahler changed the title feat(i18n): fix confirm delete feat(i18n): fix confirm delete dialog Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Package Documentation Change
sanity +22%
@sanity/types +2%
sanity/desk +2%
Full Report
sanity
This branch Next branch
148 documented 122 documented
850 not documented 831 not documented
@sanity/types
This branch Next branch
54 documented 53 documented
233 not documented 233 not documented
sanity/desk
This branch Next branch
84 documented 83 documented
56 not documented 55 not documented
@sanity/diff
This branch Next branch
13 documented 13 documented
16 not documented 16 not documented
@sanity/block-tools
This branch Next branch
4 documented 4 documented
9 not documented 9 not documented
@sanity/portable-text-editor
This branch Next branch
21 documented 21 documented
44 not documented 44 not documented
@sanity/mutator
This branch Next branch
7 documented 7 documented
4 not documented 4 not documented
@sanity/cli
This branch Next branch
1 documented 1 documented
30 not documented 30 not documented
@sanity/schema/_internal
This branch Next branch
0 documented 0 documented
9 not documented 9 not documented
@sanity/util/paths
This branch Next branch
1 documented 1 documented
15 not documented 15 not documented
sanity/router
This branch Next branch
15 documented 15 documented
21 not documented 21 not documented
@sanity/util/legacyDateFormat
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/schema
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
sanity/cli
This branch Next branch
2 documented 2 documented
0 not documented 0 not documented
@sanity/vision
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
@sanity/util/fs
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
sanity/_internal
This branch Next branch
0 documented 0 documented
1 not documented 1 not documented
@sanity/util/content
This branch Next branch
1 documented 1 documented
5 not documented 5 not documented

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Component Testing Report Updated Nov 7, 2023 12:38 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 16s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 3s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 6s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 16s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 8s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 38s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 6s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 3s 3 0 0

@ricokahler ricokahler requested a review from rexxars November 7, 2023 00:40
Copy link
Contributor

@jtpetty jtpetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ricokahler ricokahler merged commit 7cf3b66 into feat/i18n Nov 9, 2023
36 of 37 checks passed
@ricokahler ricokahler deleted the feat/i18n_fix-confirm-delete branch November 9, 2023 17:33
rexxars pushed a commit that referenced this pull request Nov 17, 2023
* fix(i18n): move `context` to props

* feat(i18n): fix spelling in comments
rexxars pushed a commit that referenced this pull request Nov 20, 2023
* fix(i18n): move `context` to props

* feat(i18n): fix spelling in comments
rexxars pushed a commit that referenced this pull request Nov 22, 2023
* fix(i18n): move `context` to props

* feat(i18n): fix spelling in comments
bjoerge pushed a commit that referenced this pull request Nov 27, 2023
* fix(i18n): move `context` to props

* feat(i18n): fix spelling in comments
bjoerge pushed a commit that referenced this pull request Nov 28, 2023
* fix(i18n): move `context` to props

* feat(i18n): fix spelling in comments
rexxars pushed a commit that referenced this pull request Nov 28, 2023
* fix(i18n): move `context` to props

* feat(i18n): fix spelling in comments
rexxars pushed a commit that referenced this pull request Nov 28, 2023
* fix(i18n): move `context` to props

* feat(i18n): fix spelling in comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants