Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components] Fix: unable to close reference search popover #463

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Jan 8, 2018

Fixed by making the loading message and no results message be escapable & closeable

Copy link
Contributor

@kristofferjs kristofferjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoerge bjoerge changed the title [components] Make loading message and no results message be escapable & closeable [components] Fix: unable to close reference search popover Jan 8, 2018
@bjoerge bjoerge merged commit dec4e5b into next Jan 8, 2018
@bjoerge bjoerge deleted the bug-cannot-close-select-when-no-hits branch January 8, 2018 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants