[schema] Fix edge case where accessing type.preview would fail #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexxars
requested changes
Sep 28, 2017
| @@ -39,7 +39,8 @@ function resolveFileAssetPath(typeDef) { | |||
| return fieldWithFileAsset ? `${fieldWithFileAsset.name}.asset` : undefined | |||
| } | |||
|
|
|||
| export default function guessPreviewFields(objectTypeDef) { | |||
| export default function guessPreviewFields(rawObjectTypeDef) { | |||
| const objectTypeDef = {fields: [], ...objectTypeDef} | |||
There was a problem hiding this comment.
Shouldn't this be ...rawObjectTypeDef?
bjoerge
force-pushed
the
fix-preview-getter-error
branch
from
81591af
to
7c1d270
Compare
rexxars
approved these changes
Sep 28, 2017
skogsmaskin
pushed a commit
that referenced
this pull request
Sep 29, 2017
Merged
bjoerge
added a commit
that referenced
this pull request
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.