Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Normalize dependency versions #184

Merged
merged 1 commit into from
Sep 20, 2017
Merged

[chore] Normalize dependency versions #184

merged 1 commit into from
Sep 20, 2017

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Sep 18, 2017

This PR normalizes versions for dependencies across different projects.
Slightly faster install/bootstrapping etc.

It also upgrades yarn to v1.0.2.

@bjoerge
Copy link
Member

bjoerge commented Sep 19, 2017

This is great! Looks like its mainly dev dependencies that has been upgraded, but it may be a good idea to hold off merge until after the upcoming release? (just to be on the safe side). What do you think?

@rexxars
Copy link
Member Author

rexxars commented Sep 19, 2017

Yup, lets wait with this one.

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased this, and also downgraded React to latest 15.x as dev dependency in a few places (we should probably stick to 15.x in development to avoid accidentally relying on 16.x specific features)

@rexxars rexxars merged commit eda91be into next Sep 20, 2017
@rexxars rexxars deleted the normalize-versions branch September 20, 2017 08:19
@bjoerge bjoerge mentioned this pull request Sep 21, 2017
bjoerge pushed a commit that referenced this pull request Sep 21, 2017
rexxars added a commit that referenced this pull request Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants