Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base] Expose schema creator as CommonJS #179

Merged
merged 1 commit into from
Sep 19, 2017
Merged

[base] Expose schema creator as CommonJS #179

merged 1 commit into from
Sep 19, 2017

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Sep 18, 2017

Being able to use CommonJS when defining your schemas is a feature I've wanted without doing the .default-dance.

@bjoerge
Copy link
Member

bjoerge commented Sep 19, 2017

Apart from the inconsistency in import / module.exports syntax, I'm OK with this.

Is this something we should try to do more consistently throughout the project?

@rexxars
Copy link
Member Author

rexxars commented Sep 19, 2017

I would say so. Let's talk about it IRL.

@rexxars rexxars merged commit 269a50c into next Sep 19, 2017
@rexxars rexxars deleted the export-schema-creator-as-cjs branch September 19, 2017 09:19
@bjoerge bjoerge mentioned this pull request Sep 19, 2017
Merged
bjoerge pushed a commit that referenced this pull request Sep 19, 2017
@rexxars @bjoerge
[base] Expose schema creator as CommonJS (#179)
c1c8cfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoerge bjoerge bjoerge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rexxars @bjoerge