Feature/date refactor #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
force-pushed
the
feature/date-refactor
branch
from
e2fab1c
to
c09f1c4
Compare
bjoerge
force-pushed
the
feature/date-refactor
branch
2 times, most recently
from
acd07a4
to
9710d38
Compare
[date-input] Rename Date --> RichDate. Add Date, which produces a plain string instead of an object. [schema] Date is now represented by a string [date-input] Date now returns a localized or utc string, depending on schema options [date-input] Remove richDate legacy string support and tidy up comments [form-builder] Declare RichDateInput
…tudio [date-input] Rename date => richDate and deprecate type: date usage
bjoerge
force-pushed
the
feature/date-refactor
branch
from
9710d38
to
cc25eff
Compare
bjoerge
pushed a commit
that referenced
this pull request
Sep 20, 2017
[base] Add richDate schema type [date-input] Rename Date --> RichDate. Add Date, which produces a plain string instead of an object. [schema] Date is now represented by a string [date-input] Date now returns a localized or utc string, depending on schema options [date-input] Remove richDate legacy string support and tidy up comments [form-builder] Declare RichDateInput [schema] Remove date type completely [example-studio] Setup test case for richDate / deprecation in test studio [date-input] Rename date => richDate and deprecate type: date usage [base] Add richDate to base schema [form-builder] Add RichDate to input resolver + add converter for date => richDate [schema] Add link to deprecation warning
Merged
bjoerge
pushed a commit
that referenced
this pull request
Sep 21, 2017
[base] Add richDate schema type [date-input] Rename Date --> RichDate. Add Date, which produces a plain string instead of an object. [schema] Date is now represented by a string [date-input] Date now returns a localized or utc string, depending on schema options [date-input] Remove richDate legacy string support and tidy up comments [form-builder] Declare RichDateInput [schema] Remove date type completely [example-studio] Setup test case for richDate / deprecation in test studio [date-input] Rename date => richDate and deprecate type: date usage [base] Add richDate to base schema [form-builder] Add RichDate to input resolver + add converter for date => richDate [schema] Add link to deprecation warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready now, but we should probably hold off merging and coordinate with the block text migration.