[chore] Support React 16.0.0-rc.2 as peer dependency #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've downgraded to latest 15.x in test studio and example studio for now, so this should be good to merge now. |
thomax
pushed a commit
that referenced
this pull request
Sep 14, 2017
bjoerge
added a commit
that referenced
this pull request
Sep 14, 2017
Merged
bjoerge
added a commit
that referenced
this pull request
Sep 19, 2017
skogsmaskin
pushed a commit
that referenced
this pull request
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also upgrades React to 16.0.0-rc.2 in test studio and example studio.
Ran into a few issues along the way:
react-json-inspectorto @rexxars' react-15 branch here, which fixes the deprecation warnings in React 15 that are hard errors in 16. (we should probably look for an alternative, since react-json-inspector doesn't seem like its actively maintained anymore).Apart from that, everything seems to work fine with 16.0.0-rc.2 🎉