[core] Skip system documents when exporting a dataset #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
pushed a commit
that referenced
this pull request
Aug 18, 2017
bjoerge
pushed a commit
that referenced
this pull request
Aug 22, 2017
bjoerge
pushed a commit
that referenced
this pull request
Aug 23, 2017
bjoerge
pushed a commit
that referenced
this pull request
Aug 24, 2017
Merged
bjoerge
pushed a commit
that referenced
this pull request
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you export a dataset, both system groups and listeners are included.
When you try to import this into a new dataset, you get permission errors since these kind of documents cannot be inserted by a regular user without the
manageflag.The best solution would be if we could filter these documents on the server side, but as of now we can't do this. This PR filters them on the client side when you run
sanity dataset export.