Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sanity] Update dependency jsdom to remove deprecated packages. #5316

Closed
Wundero opened this issue Dec 3, 2023 · 1 comment · Fixed by #5327
Closed

[sanity] Update dependency jsdom to remove deprecated packages. #5316

Wundero opened this issue Dec 3, 2023 · 1 comment · Fixed by #5327

Comments

@Wundero
Copy link

Wundero commented Dec 3, 2023

If you find a security vulnerability, do NOT open an issue. Email [email protected] instead.

Describe the bug

The normal Sanity npm package ([email protected]) uses [email protected], which depends on two deprecated packages: abab and domexception, which both have native variants now. [email protected] removed both of these dependencies, and as such should be preferred. jsdom-global should work just fine with the new version.

To Reproduce

Simply installing the package will produce deprecation errors, like the following:
image

Expected behavior

No warnings when installing sanity.

Which versions of Sanity are you using?

3.20.2

What operating system are you using?

Windows 10

Which versions of Node.js / npm are you running?

Node: v20.3.1
npm: 9.6.7
pnpm: 8.6.6

rexxars added a commit that referenced this issue Dec 5, 2023
@rexxars rexxars changed the title [sanity] Update depenedency jsdom to remove deprecated packages. [sanity] Update dependency jsdom to remove deprecated packages. Dec 5, 2023
juice49 pushed a commit that referenced this issue Dec 17, 2023
Copy link
Contributor

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant