fix: minor regression with menu item spacing

sanity-io · Dec 19, 2023 · 41caf72 · 41caf72
1 parent d09822e
commit 41caf72
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/packages/sanity/src/ui/__workshop__/MenuItemStory.tsx b/packages/sanity/src/ui/__workshop__/MenuItemStory.tsx
@@ -6,7 +6,7 @@ import React from 'react'
 import {MenuItem} from '../menuItem'
 
 const HOTKEYS = ['Ctrl', 'Alt', 'P']
-const AVATAR_INITIALS = 'A.W.'
+const AVATAR_INITIALS = 'AW'
 
 export default function MenuItemStory() {
   const text = useString('Text', 'Text', 'Props') || ''

diff --git a/packages/sanity/src/ui/menuItem/MenuItem.tsx b/packages/sanity/src/ui/menuItem/MenuItem.tsx
@@ -75,17 +75,19 @@ export const MenuItem = forwardRef(function MenuItem(
     return (
       <Flex align="center" gap={2}>
         {preview && (
-          <PreviewWrapper paddingX={1}>
+          <PreviewWrapper>
             <Flex align="center" height="fill" justify="center">
               {preview}
             </Flex>
           </PreviewWrapper>
         )}
         {icon && (
-          <Text size={FONT_SIZE}>
-            {isValidElement(icon) && icon}
-            {isValidElementType(icon) && createElement(icon)}
-          </Text>
+          <Box paddingRight={1}>
+            <Text size={FONT_SIZE}>
+              {isValidElement(icon) && icon}
+              {isValidElementType(icon) && createElement(icon)}
+            </Text>
+          </Box>
         )}
         {text && (
           <Stack flex={1} space={2}>