fix(portable-text-editor): check that path is lengthy (#5875)

* fix(portable-text-editor): check that path is lengthy Empty paths should not be returned, as it doesn't make sense and leads to bugs. * test(portable-text-editor): fix failing test
sanity-io · Feb 29, 2024 · 2deebb1 · 2deebb1
1 parent fc73437
commit 2deebb1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/...le-text-editor/src/editor/plugins/__tests__/withEditableAPISelectionsOverlapping.test.tsx b/...le-text-editor/src/editor/plugins/__tests__/withEditableAPISelectionsOverlapping.test.tsx
@@ -9,7 +9,7 @@ import {PortableTextEditor} from '../../PortableTextEditor'
 const INITIAL_VALUE: PortableTextBlock[] = [
   {
     _key: 'a',
-    _type: 'block',
+    _type: 'myTestBlockType',
     children: [
       {
         _key: 'a1',

diff --git a/packages/@sanity/portable-text-editor/src/utils/ranges.ts b/packages/@sanity/portable-text-editor/src/utils/ranges.ts
@@ -53,6 +53,9 @@ export function toSlateRange(selection: EditorSelection, editor: Editor): Range
     path: createArrayedPath(selection.focus, editor),
     offset: selection.focus.offset,
   }
+  if (focus.path.length === 0 || anchor.path.length === 0) {
+    return null
+  }
   const range = anchor && focus ? {anchor, focus} : null
   return range
 }