Replacing assignation by typing for websocket_handshake
#2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahopkins
previously approved these changes
Oct 15, 2021
ashleysommer
previously approved these changes
Oct 15, 2021
prryplatypus
previously approved these changes
Oct 15, 2021
ahopkins
dismissed stale reviews from prryplatypus, ashleysommer, and themself
via
11cfdca
ahopkins
previously approved these changes
Oct 17, 2021
Tronic
reviewed
Oct 17, 2021
ahopkins
requested review from
ashleysommer,
Tronic,
prryplatypus and
sjsadowski
Tronic
previously approved these changes
Oct 26, 2021
ChihweiLHBird
pushed a commit
to ChihweiLHBird/sanic
that referenced
this pull request
Jun 1, 2022
…2273) * Replacing assignation by typing for `websocket_handshake` Related to sanic-org#2272 * Fix some type hinting issues * Cleanup websocket handchake response concat * Optimize concat encoding Co-authored-by: Adam Hopkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2272