Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeComparators #989

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Fix TypeComparators #989

merged 2 commits into from
Mar 31, 2023

Conversation

filosganga
Copy link
Contributor

Fix the isSubType of typeComparator and add specific tests

filosganga
filosganga commented Mar 31, 2023
View reviewed changes
modules/core/src/main/scala/sangria/schema/Schema.scala Outdated
}
} ++ unionTypes.values.map(ut => ut.name -> ut.types.toVector)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I don't like this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a better idea?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I have changed back and use union only in possibleTypes

@yanns yanns added this pull request to the merge queue Mar 31, 2023
Merged via the queue into sangria-graphql:main with commit 3f3a5d1 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanns yanns yanns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filosganga @yanns