Values of correct type when validating SDL. Fixes #965

[maloku]

No description provided.

[maloku]

@yanns do you think these tests are because of the changes I made? If I revert my changes, some tests do fail. Am I missing something?

[yanns]

For me, all tests are passing on main. It's also a prerequisite for any PR to be merged.
When I checkout your PR, sangria.schema.AstSchemaMaterializerSpec is failing. So it should be related to your changes.
But don't panic: check how the tests are failing. Maybe we should update the tests if they show an issue.

[maloku]

Oh - that was a good catch. My change ended up validating comments which are ast.StringValue with the type of argument which contains the default value. I adopted it now, and the failing test AstSchemaMaterializerSpec is passing.

When I run sbt test I get 4 test failed on main - this is the reason I asked because I expected some test to fail:

[info] Tests: succeeded 1246, failed 4, canceled 0, ignored 1, pending 0
[info] *** 4 TESTS FAILED ***
[error] Failed tests:
[error]         sangria.marshalling.QueryAstMarshallingSupportSpec
[error]         sangria.macros.LiteralMacroSpec
[error]         sangria.renderer.SchemaRenderSpec

Let's see now

[yanns]

When I run sbt test I get 4 test failed on main - this is the reason I asked because I expected some test to fail:

[info] Tests: succeeded 1246, failed 4, canceled 0, ignored 1, pending 0
[info] *** 4 TESTS FAILED ***
[error] Failed tests:
[error]         sangria.marshalling.QueryAstMarshallingSupportSpec
[error]         sangria.macros.LiteralMacroSpec
[error]         sangria.renderer.SchemaRenderSpec

Can you check that further? It's not expected.

[yanns]

I really appreciate the attention you gave to the tests! 💯
As I'm not completely sure about the impact of this change, I'll do the following:

• merge this PR
• cut a RC release
• try this RC release (you can also try the RC release if you want)
  If everything is good, then we'll go with a stable release.
  If we notice an issue, we can check it.

[yanns]

I've tried https://github.com/sangria-graphql/sangria/releases/tag/v3.5.3-RC1 on internal applications, and it does not break anything ;)

[maloku]

Great! I do not have a production application as I am only learning (in detail) GraphQL and just happened to pick Scala and Sangria for this journey. But I am still at the beginning, so I may come back with additional stuff, who knows? Thank you so much for supporting me.