Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the configs for new RabbitMQ instance #1450

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

dasunpubudumal
Copy link
Contributor

@dasunpubudumal dasunpubudumal commented Oct 7, 2024

Closes #

Changes proposed in this pull request

Here's my attempt to explain a bit of the setup: https://ssg-confluence.internal.sanger.ac.uk/display/PSDPUB/PSD-managed+RabbitMQ+for+test+environments.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (b8ed416) to head (9016a10).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1450   +/-   ##
========================================
  Coverage    97.90%   97.90%           
========================================
  Files          422      422           
  Lines        13173    13173           
========================================
  Hits         12897    12897           
  Misses         276      276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@seenanair seenanair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to update the bunny.yml.example with the key-name change from 'isg' to 'broker' as well as in the documentaion.

Also, I hope you have updated similarly in deployment project as well.

@dasunpubudumal
Copy link
Contributor Author

It would be good to update the bunny.yml.example with the key-name change from 'isg' to 'broker' as well as in the documentaion.

Also, I hope you have updated similarly in deployment project as well.

Hi @seenanair, yes the deployment project was updated. The PR is https://github.com/sanger/deployment/pull/496.

@dasunpubudumal dasunpubudumal merged commit 6e7693c into develop Oct 22, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants