-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y24-398 - scRNA Pooling scenario restriction to study-project level #4437
Y24-398 - scRNA Pooling scenario restriction to study-project level #4437
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4437 +/- ##
===========================================
- Coverage 86.48% 86.40% -0.09%
===========================================
Files 1390 1390
Lines 29770 29774 +4
===========================================
- Hits 25747 25725 -22
- Misses 4023 4049 +26 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was nice and neat to adapt :) I just spotted a problem with the original implementation... would you be up for fixing it as part of this story? It's meant to do the validation for 2 fields, 'number of samples/pool' and 'number of cells /chip well', but it only seems to do it for one of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(link to original story - #4337)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 87e277e
"Inconsistent values for column 'scRNA Core Number of Samples per Pool' for " \ | ||
"Study name 'abc123_study', all rows for a specific study must have the same value" | ||
"Inconsistent values for column 'scRNA Core Number of Samples per Pool' for Study name 'abc123_study' " \ | ||
"and Project name 'Test project', all rows for a specific study and project must have the same value" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add a new test to check the new behaviour - that it DOES allow different values for different projects within the same study.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I manually tested it but will add a unit test. Ill try see if there is a nicer way to handle the CSV differences instead of making a separate file for each test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a line in the valid sample sheet to cover this case. Same study, different project, different samples per pool, different cells per chip well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. Requested a couple of changes.
… checks for cells per chip well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes.
Closes #4422
Changes proposed in this pull request