Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add uuid to tube purpose resource #4230

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Conversation

KatyTaylor
Copy link
Contributor

@KatyTaylor KatyTaylor commented Jul 25, 2024

Closes #

Changes proposed in this pull request

  • it was breaking Limber config generate task as that needed to retrieve the uuid
  • copied over from the plate purpose resource

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

- it was breaking Limber config generate task as that needed to retrieve the uuid
- copied over from the plate purpose resource
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.82%. Comparing base (6bd607f) to head (85f9a04).
Report is 25 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4230      +/-   ##
===========================================
+ Coverage    86.78%   86.82%   +0.04%     
===========================================
  Files         1369     1369              
  Lines        29726    29744      +18     
===========================================
+ Hits         25797    25825      +28     
+ Misses        3929     3919      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sdjmchattie sdjmchattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update the tests to make sure this cannot be set during creation or updated. I think we also need to default_includes :uuid near the top of the resource.

app/resources/api/v2/tube_purpose_resource.rb Outdated Show resolved Hide resolved
@KatyTaylor
Copy link
Contributor Author

I think we need to update the tests to make sure this cannot be set during creation or updated. I think we also need to default_includes :uuid near the top of the resource.

okidoke


it 'returns 400, because uuid is read-only' do
api_patch "#{base_endpoint}/#{resource_model.id}", payload
expect(response).to have_http_status(400)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fix these 400s as github suggests I think

@KatyTaylor KatyTaylor merged commit fbc7ea9 into develop Jul 26, 2024
21 checks passed
@KatyTaylor KatyTaylor deleted the config_generate_fix branch July 26, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants