-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add uuid to tube purpose resource #4230
Conversation
- it was breaking Limber config generate task as that needed to retrieve the uuid - copied over from the plate purpose resource
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4230 +/- ##
===========================================
+ Coverage 86.78% 86.82% +0.04%
===========================================
Files 1369 1369
Lines 29726 29744 +18
===========================================
+ Hits 25797 25825 +28
+ Misses 3929 3919 -10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to update the tests to make sure this cannot be set during creation or updated. I think we also need to default_includes :uuid
near the top of the resource.
Co-authored-by: Stuart McHattie <[email protected]>
okidoke |
- and add tests to check that
… into config_generate_fix
|
||
it 'returns 400, because uuid is read-only' do | ||
api_patch "#{base_endpoint}/#{resource_model.id}", payload | ||
expect(response).to have_http_status(400) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just fix these 400s as github suggests I think
Closes #
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version