Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-266 LCM Triomics pipeline configuration and integration test for EMSeq branch #1879

Conversation

yoldas
Copy link
Member

@yoldas yoldas commented Aug 29, 2024

Closes #

Changes proposed in this pull request

  • LCM Triomics EMSeq branch config

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (6aec2b9) to head (db26508).
Report is 124 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1879      +/-   ##
===========================================
- Coverage    74.54%   69.69%   -4.85%     
===========================================
  Files          421      429       +8     
  Lines        14379    15739    +1360     
===========================================
+ Hits         10719    10970     +251     
- Misses        3660     4769    +1109     
Flag Coverage Δ
javascript 52.15% <ø> (-7.49%) ⬇️
pull_request 74.92% <ø> (?)
push 74.54% <ø> (ø)
ruby 91.43% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoldas yoldas marked this pull request as ready for review September 9, 2024 10:39
Copy link
Member

@andrewsparkes andrewsparkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor naming changes requested

config/pipelines/high_throughput_lcm_triomics.wip.yml Outdated Show resolved Hide resolved
config/purposes/lcm_triomics.wip.yml Show resolved Hide resolved
config/pipelines/high_throughput_lcm_triomics.wip.yml Outdated Show resolved Hide resolved
config/pipelines/high_throughput_lcm_triomics.wip.yml Outdated Show resolved Hide resolved
config/purposes/lcm_triomics.wip.yml Outdated Show resolved Hide resolved
config/pipelines/high_throughput_lcm_triomics.wip.yml Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Sep 17, 2024

Code Climate has analyzed commit db26508 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.

Copy link
Member

@andrewsparkes andrewsparkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@yoldas yoldas merged commit d616f27 into develop Sep 17, 2024
13 of 14 checks passed
@yoldas yoldas deleted the y24-266---lcm-triomics-pipeline-configuration-and-integration-test-for-emseq-branch branch September 17, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-266 - LCM Triomics Pipeline configuration and integration test for EMSeq branch
3 participants