This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
forked from nf-core/modules
-
Notifications
You must be signed in to change notification settings - Fork 2
Merge requests
Priyanka Surana edited this page May 6, 2022
·
24 revisions
- Linting
nf-core modules lint <software/tool> --dir .
Repeat the above command till you have all errors resolved.
- Testing
TMPDIR=~ PROFILE=singularity pytest --tag <software/tool> --symlink --keep-workflow-wd --git-aware
- Staging
git add ./modules/<software_tool> ./tests/modules/<software_tool> ./tests/config/pytest_modules.yml
- Commit changes
git commit -m "Adding module for <software/tool>. Closes #<issue_number>.
- Push changes
git push -u origin <software_tool>
- Create PR
- Go to https://github.com/sanger-tol/nf-core-modules
- Set base branch to
sanger-tol/nf-core-modules:main
- Set compare to
sanger-tol/nf-core-modules:<software_tool>
- Click on "Create pull request"
- Fill out the template. Please check all boxes that apply, it helps with the review. Fill in
Closes #XXX
, it helps with automation.
- The review process is a back and forth collaborative exercise. Once complete, your PR is merged and the issue is closed.
-
Create an issue for a new module in
nf-core/modules
-
Create a new PR for
nf-core/modules
- Go to https://github.com/nf-core/modules/compare
- Click
compare across forks
- Set base branch to
nf-core/modules:master
- Set compare to
sanger-tol/nf-core-modules:<software_tool>
- Click on "Create pull request"
- Fill out the template. Please check all boxes that apply and fill in
Closes #XXX
.
-
Going through the PR review in
nf-core
is personal choice. But creating the PR innf-core/modules
ensures you get the credit if this module is further developed. And also allows us to contribute to a community that helps us out. -
For any questions, concerns or issues, please message either Matthieu (mm49) or Priyanka (ps22). Happy Coding 👩💻