Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for grid view (and a few other things) #114

Merged
merged 22 commits into from
Oct 2, 2024
Merged

Support for grid view (and a few other things) #114

merged 22 commits into from
Oct 2, 2024

Conversation

muffato
Copy link
Member

@muffato muffato commented Sep 20, 2024

The original purpose (TOLIT-2292) was to generate additional metadata in the blobDir to support the grid view that Karen would like to embed into the genome notes.

Talking to Rich, this is essentially the last major feature that needs to be implemented for the v1.0 release, so I had a go at all the other minor changes I wanted for v1.0:

  • The blobDir metadata needs to record whether the reads are paired or single (TOLIT-2525)
  • Updated the documentation (TOLIT-2522)
  • "Publish" all important output files (TOLIT-2521)
  • Convert input BAM/CRAM files to Fasta on the fly into minimap2. This saves a lot of space and time (I/O)

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@muffato muffato self-assigned this Sep 20, 2024
Copy link

github-actions bot commented Sep 20, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1909646

+| ✅ 128 tests passed       |+
#| ❔  29 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-blobtoolkit_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-blobtoolkit_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-blobtoolkit_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: conf/igenomes.config
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting_comment.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: assets/nf-core-blobtoolkit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-blobtoolkit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-blobtoolkit_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/blobtoolkit/blobtoolkit/.github/workflows/awstest.yml
  • template_strings - template_strings
  • merge_markers - merge_markers

✅ Tests passed:

Run details

  • nf-core/tools version 2.11
  • Run at 2024-10-02 07:29:46

@muffato muffato changed the title Support for grid view (and a few other things before v1.0) Support for grid view (and a few other things) Sep 26, 2024
@muffato
Copy link
Member Author

muffato commented Sep 26, 2024

Edit: I've decided that I won't be calling this v1.0 just yet. I think it's imperative to sort out the resource usage first (Hi-C minimap2 alignments shouldn't be going to the basement queue) and the blastn issue.

@muffato muffato marked this pull request as ready for review September 26, 2024 14:53
@tkchafin tkchafin self-requested a review September 30, 2024 08:47
Copy link

@tkchafin tkchafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent all of my changes as commits

@muffato muffato merged commit 102dbf4 into dev Oct 2, 2024
6 checks passed
@muffato muffato deleted the chrom_view branch October 2, 2024 08:12
@muffato muffato mentioned this pull request Oct 2, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants