-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert some class Java to Kotlin with Refactoring #175
Merged
sangcomz
merged 6 commits into
sangcomz:develop
from
laco-dev:feature/java-to-kotlin/core
Oct 7, 2019
Merged
Convert some class Java to Kotlin with Refactoring #175
sangcomz
merged 6 commits into
sangcomz:develop
from
laco-dev:feature/java-to-kotlin/core
Oct 7, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature: * WeakReference<(activity, fragment)> in FishBun >>> WeakReference<Activity> - Just runs startActivityForResult method
feature: * Add getter and setter where using the fields in "Fishton" When complete of converting, do resolves (for kotlin property) [Adapter, Activity, etc...] * Add ContextUtil for take String resources *
…Result" from fragment.
sangcomz
reviewed
Sep 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check two comments. Thank you!
laco-dev
force-pushed
the
feature/java-to-kotlin/core
branch
from
October 3, 2019 14:05
c0389cc
to
4ee9126
Compare
…ature/java-to-kotlin/core # Conflicts: # FishBun/src/main/java/com/sangcomz/fishbun/ui/picker/PickerActivity.java
laco-dev
force-pushed
the
feature/java-to-kotlin/core
branch
from
October 4, 2019 15:36
4ee9126
to
e40c1a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
This PR changes: Convert java to kotlin with Refactoring
Fishton
Etc.
activity
andfragment
field inFishBun
to Context(type: Activity)startActivityForResult
onActivityResult
method inWithActvitiyActivity
SubFragment