Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert some class Java to Kotlin with Refactoring #175

Merged
merged 6 commits into from
Oct 7, 2019

Conversation

laco-dev
Copy link
Contributor

Fixes issue
  • No Issue
This PR changes: Convert java to kotlin with Refactoring
  • Convert to

BaseProperty.java CustomizationProperty.java
FishBun.java Fishton.java FishBunCreator.java

  • Some change to: Change modifier of property in Fishton
    • Java public field >>> Kotlin property
    • So, Just change getter, setter in below class
    • It would be change when convert to kotlin (Please, review simply)

AlbumListAdapter DetailViewPagerAdapter PickerGridAdapter
AlbumActivity DetailActivity PickerActivity

Etc.

  • Change activity and fragment field in FishBun to Context(type: Activity)
    • It just runs startActivityForResult
  • Add onActivityResult method in WithActvitiyActivity
    • Bug: It could not receive from SubFragment
  • Not added dependencies of kotlin.

feature:
   * WeakReference<(activity, fragment)> in FishBun >>> WeakReference<Activity>
      - Just runs startActivityForResult method
feature:
   * Add getter and setter where using the fields in "Fishton" When complete of converting, do resolves (for kotlin property) [Adapter, Activity, etc...]
   * Add ContextUtil for take String resources
   *
Copy link
Owner

@sangcomz sangcomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check two comments. Thank you!

FishBun/src/main/java/com/sangcomz/fishbun/FishBun.kt Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@b378795). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #175   +/-   ##
=========================================
  Coverage           ?   0.11%           
=========================================
  Files              ?      31           
  Lines              ?    1667           
  Branches           ?     198           
=========================================
  Hits               ?       2           
  Misses             ?    1665           
  Partials           ?       0
Impacted Files Coverage Δ
...com/sangcomz/fishbun/ui/detail/DetailActivity.java 0% <0%> (ø)
...a/com/sangcomz/fishbun/ui/album/AlbumActivity.java 0% <0%> (ø)
...angcomz/fishbun/adapter/view/AlbumListAdapter.java 0% <0%> (ø)
...ngcomz/fishbun/adapter/view/PickerGridAdapter.java 0% <0%> (ø)
...c/main/java/com/sangcomz/fishbun/FishBunCreator.kt 0% <0%> (ø)
...com/sangcomz/fishbun/ui/picker/PickerActivity.java 0% <0%> (ø)
...hBun/src/main/java/com/sangcomz/fishbun/Fishton.kt 0% <0%> (ø)
...z/fishbun/adapter/view/DetailViewPagerAdapter.java 0% <0%> (ø)
...hBun/src/main/java/com/sangcomz/fishbun/FishBun.kt 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b378795...e40c1a9. Read the comment docs.

…ature/java-to-kotlin/core

# Conflicts:
#	FishBun/src/main/java/com/sangcomz/fishbun/ui/picker/PickerActivity.java
@sangcomz sangcomz merged commit 66c946b into sangcomz:develop Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants