fix(dat-convert): change default conversion behavior to match UM #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbhart
commented
Nov 4, 2024
Update to include both -depth and -height configuraiton options for brine injection, production, and interface.
|
Patch coverage of 89.65% is close enough to 90.73% to continue this merge |
ci: update codecov config
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 90.73% 90.78% +0.05%
==========================================
Files 21 21
Lines 3971 3995 +24
Branches 280 280
==========================================
+ Hits 3603 3627 +24
Misses 368 368
|
Signed-off-by: David Hart <[email protected]>
Rename regression testing output files to be explicitly .txt to avoid filetype confusion.
hgmaure
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional comments to scenarios converted from .DAT files.
Change subsequent-stage cavern SG initialization to match UM-documented behavior rather than undocumented reset behavior.