Patch reset cavern sg on new stage start #25
Conversation
|
@hgmaure if you don't mind reviewing the changes in this PR since you found the bug, I'd appreciate it! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 86.21% 86.14% -0.08%
==========================================
Files 8 8
Lines 2010 1992 -18
==========================================
- Hits 1733 1716 -17
+ Misses 277 276 -1
|
Signed-off-by: David Hart <[email protected]>
dbhart
added
bug
Bring up to date with main
Signed-off-by: David Hart <[email protected]>
There was a problem hiding this comment.
This is pulling in build process changes and is not related to the bug fix
There was a problem hiding this comment.
Not part of the bugfix, this change helps VSCode users not check in private workspace files
There was a problem hiding this comment.
Not part of the bugfix, this provides links to badges on pypi
There was a problem hiding this comment.
Related to the bugfix. This moved the assignment to the outside of the for loop (which was unnecessary)
Unrelated to the bugfix, adds more explicit license details
There was a problem hiding this comment.
Updates warnings and does not reset cavern sg on "repeat"; this returns sansmic to previous behavior.
There was a problem hiding this comment.
Bug fix: removes the override-to-0 of the cavern SG on "REPEAT" stages that was in the Stage creation section.
There was a problem hiding this comment.
Bug fix: verifies that value was not changed when specified as non-zero in a REPEAT section.
The initial release of sansmic is supposed to mimic exactly the behavior of the old SANSMIC program. The sansmic code was set up to match the behavior stated in the SANSMIC documentation; the old documentation did not, however, match the actual behavior of the code. This patch returns the code to mimic the behavior of SANSMIC, and issues a warning that this behavior will be changed in the next release.