Nick/numpy 2 #307
Merged
Nick/numpy 2 #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Convert numpy scalars to python with .item * Make sure inputs to numpy groupies first arg is a row vector * Replace in1d
* Convert numpy scalars to python with .item * Fix some minor typing changes
dmdunla
approved these changes
Oct 23, 2024
This was referenced Oct 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #306, #309
All of this is mostly superficial, I expect we'll be tracking down the fact that a numpy scalar now prints a
np.float32_(2.0)instead of2.0for a while. But this captured everything unhappy in all of our tests. I ran python3.8 and python3.9 (with numpy 2.0) against all our tests so I'm reasonably confident this will clear CI,but my permissions changed so I'm no longer able to trigger it myself when I submit a PRhmm I guess CI does run for me but I am not able to trigger it on other MRs.I tagged on the typing_extension bit since that also is a broken pyproject config on main at the moment.
📚 Documentation preview 📚: https://pyttb--307.org.readthedocs.build/en/307/