Default behavior of divmod() is different from MATLAB mod(), on which… #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#237) * Default behavior of divmod() is different from MATLAB mod(), on which the original logic was based. The prior logic threw a ZeroDivisionError if printitn == 0. Instead, this fix avoids this error by testing that printitn > 0. Tests added for various values of printitn. * Update tests/test_cp_als.py Co-authored-by: Nick <[email protected]> * Update tests/test_cp_als.py Co-authored-by: Nick <[email protected]> * Applying Nick's suggesetions to remove mark, change maxiters to save CPU cycles. Also removing output since nothing is actually checked. * Removes mark * Closes #235 --------- Co-authored-by: Jeremy Myers <[email protected]> Co-authored-by: Nick <[email protected]>
ntjohnson1
approved these changes
Sep 16, 2023
dmdunla
deleted the
235-cp_als-with-option-printitn=0-causes-zerodivisionerror
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…… (#237)
Default behavior of divmod() is different from MATLAB mod(), on which the original logic was based. The prior logic threw a ZeroDivisionError if printitn == 0. Instead, this fix avoids this error by testing that printitn > 0. Tests added for various values of printitn.
Update tests/test_cp_als.py
Update tests/test_cp_als.py
Applying Nick's suggesetions to remove mark, change maxiters to save CPU cycles. Also removing output since nothing is actually checked.
Removes mark
Closes
cp_alswith optionprintitn=0causesZeroDivisionError#235 ---------📚 Documentation preview 📚: https://pyttb--242.org.readthedocs.build/en/242/