-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
miniweb: is born #852
miniweb: is born #852
Conversation
Somewhat functional miniweb. vms, tilevnc, and connect all seem to be working. Need to fix the graph view.
Instead of using `%v` to print a slice, use strings.Join. Makes it much simpler to parse.
Fix how networks were parsed for graph. Removing some deadcode that is not longer needed.
Add flags to configure listening address, base path, and web root. Clean up some of the code.
|
It would be neat to embed all of "misc/web" into the miniweb binary. Then we would have a single binary web. Something like this looks promising: https://github.com/rakyll/statik Should we create a bunch of miniweb issues for all the different features we want? |
sure
…On Feb 8, 2017 08:27, "Jon Crussell" ***@***.***> wrote:
It would be neat to embed all of "misc/web" into the miniweb binary. Then
we would have a single binary web. Something like this looks promising:
https://github.com/rakyll/statik
Should we create a bunch of miniweb issues for all the different features
we want?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#852 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFucxbli3cqiKCTYguuRatYjb0-vxCOks5rad7sgaJpZM4L12XI>
.
|
LGTM, and I've got the embedding of the |
Do we really care to bundle the web content in the binary these days? Anymore, we tend to package the minimega distribution as a whole - there are already tons of binaries, docs, etc. |
What's the verdict on static |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should have been update for commas in slices.
Don't merge yet, still a WIP.
Somewhat functional miniweb. vms, tilevnc, and connect all seem to be
working. Need to fix the graph view.