Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniweb: is born #852

Merged
merged 4 commits into from
Feb 27, 2017
Merged

miniweb: is born #852

merged 4 commits into from
Feb 27, 2017

Conversation

jcrussell
Copy link
Contributor

Don't merge yet, still a WIP.

Somewhat functional miniweb. vms, tilevnc, and connect all seem to be
working. Need to fix the graph view.

Somewhat functional miniweb. vms, tilevnc, and connect all seem to be
working. Need to fix the graph view.
@jcrussell jcrussell added this to the 2.4 milestone Feb 3, 2017
Instead of using `%v` to print a slice, use strings.Join. Makes it much
simpler to parse.
Fix how networks were parsed for graph. Removing some deadcode that is
not longer needed.
Add flags to configure listening address, base path, and web root. Clean
up some of the code.
@jcrussell
Copy link
Contributor Author

miniweb is now functionally the same as minimega's web server. Do we want to do a review and merge this and then figure out what things we want to add?

@djfritz @jasoncontrib @floren

@jcrussell
Copy link
Contributor Author

It would be neat to embed all of "misc/web" into the miniweb binary. Then we would have a single binary web. Something like this looks promising:

https://github.com/rakyll/statik

Should we create a bunch of miniweb issues for all the different features we want?

@floren
Copy link
Collaborator

floren commented Feb 8, 2017 via email

@jasoncontrib
Copy link
Collaborator

LGTM, and I've got the embedding of the misc/web files working using statik

@djfritz
Copy link
Contributor

djfritz commented Feb 9, 2017

Do we really care to bundle the web content in the binary these days? Anymore, we tend to package the minimega distribution as a whole - there are already tons of binaries, docs, etc.

@jcrussell
Copy link
Contributor Author

What's the verdict on static miniweb? Are we moving towards a single directory that needs to be replicated on the head node? minidoc could embed all of doc/...

Copy link
Contributor

@djfritz djfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djfritz djfritz merged commit b4ceff7 into sandia-minimega:master Feb 27, 2017
@jcrussell jcrussell deleted the miniweb branch February 27, 2017 15:57
jcrussell added a commit to jcrussell/minimega that referenced this pull request Mar 13, 2017
Should have been update for commas in slices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants