fix(api): numeric/bignumeric conversion issue googleapis#1757

sandhusanthakumar · Aug 30, 2022 · 3ab29b9 · 3ab29b9
1 parent 56b3fb7
commit 3ab29b9
Show file tree

Hide file tree

Showing 2 changed files with 59 additions and 4 deletions.
diff --git a/...igquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessage.java b/...igquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessage.java
@@ -313,7 +313,7 @@ private static void fillField(
               protoMsg.setField(
                   fieldDescriptor,
                   BigDecimalByteStringEncoder.encodeToNumericByteString(
-                      new BigDecimal(((Number) val).doubleValue())));
+                      new BigDecimal(String.valueOf(val))));
               return;
             }
           } else if (fieldSchema.getType() == TableFieldSchema.Type.BIGNUMERIC) {
@@ -333,7 +333,7 @@ private static void fillField(
               protoMsg.setField(
                   fieldDescriptor,
                   BigDecimalByteStringEncoder.encodeToBigNumericByteString(
-                      new BigDecimal(((Number) val).doubleValue())));
+                      new BigDecimal(String.valueOf(val))));
               return;
             }
           }
@@ -547,7 +547,7 @@ private static void fillRepeatedField(
               protoMsg.addRepeatedField(
                   fieldDescriptor,
                   BigDecimalByteStringEncoder.encodeToNumericByteString(
-                      new BigDecimal(((Number) val).doubleValue())));
+                      new BigDecimal(String.valueOf(val))));
               added = true;
             }
           } else if (fieldSchema != null
@@ -568,7 +568,7 @@ private static void fillRepeatedField(
               protoMsg.addRepeatedField(
                   fieldDescriptor,
                   BigDecimalByteStringEncoder.encodeToBigNumericByteString(
-                      new BigDecimal(((Number) val).doubleValue())));
+                      new BigDecimal(String.valueOf(val))));
               added = true;
             }
           }

diff --git a/...erystorage/src/test/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessageTest.java b/...erystorage/src/test/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessageTest.java
@@ -27,6 +27,7 @@
 import com.google.protobuf.Message;
 import java.math.BigDecimal;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.Map;
 import java.util.logging.Logger;
 import org.json.JSONArray;
@@ -1311,4 +1312,58 @@ public void testNullRepeatedField() throws Exception {
         JsonToProtoMessage.convertJsonToProtoMessage(RepeatedInt32.getDescriptor(), ts, json);
     assertTrue(protoMsg.getAllFields().isEmpty());
   }
+
+  @Test
+  public void testDoubleAndFloatToNumericConversion() {
+    TableSchema ts =
+        TableSchema.newBuilder()
+            .addFields(
+                0,
+                TableFieldSchema.newBuilder()
+                    .setName("numeric")
+                    .setType(TableFieldSchema.Type.NUMERIC)
+                    .build())
+            .build();
+    TestNumeric expectedProto =
+        TestNumeric.newBuilder()
+            .setNumeric(
+                BigDecimalByteStringEncoder.encodeToNumericByteString(new BigDecimal("24.678")))
+            .build();
+    JSONObject json = new JSONObject();
+    json.put("numeric", new Double(24.678));
+    DynamicMessage protoMsg =
+        JsonToProtoMessage.convertJsonToProtoMessage(TestNumeric.getDescriptor(), ts, json);
+    assertEquals(expectedProto, protoMsg);
+    json.put("numeric", new Float(24.678));
+    protoMsg = JsonToProtoMessage.convertJsonToProtoMessage(TestNumeric.getDescriptor(), ts, json);
+    assertEquals(expectedProto, protoMsg);
+  }
+
+  @Test
+  public void testDoubleAndFloatToRepeatedBigNumericConversion() {
+    TableSchema ts =
+        TableSchema.newBuilder()
+            .addFields(
+                0,
+                TableFieldSchema.newBuilder()
+                    .setName("bignumeric")
+                    .setType(TableFieldSchema.Type.BIGNUMERIC)
+                    .setMode(TableFieldSchema.Mode.REPEATED)
+                    .build())
+            .build();
+    TestBignumeric expectedProto =
+        TestBignumeric.newBuilder()
+            .addBignumeric(
+                BigDecimalByteStringEncoder.encodeToBigNumericByteString(new BigDecimal("24.678")))
+            .build();
+    JSONObject json = new JSONObject();
+    json.put("bignumeric", Collections.singletonList(new Double(24.678)));
+    DynamicMessage protoMsg =
+        JsonToProtoMessage.convertJsonToProtoMessage(TestBignumeric.getDescriptor(), ts, json);
+    assertEquals(expectedProto, protoMsg);
+    json.put("bignumeric", Collections.singletonList(new Float(24.678)));
+    protoMsg =
+        JsonToProtoMessage.convertJsonToProtoMessage(TestBignumeric.getDescriptor(), ts, json);
+    assertEquals(expectedProto, protoMsg);
+  }
 }