Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and add translations #221

Closed
3 tasks done
sander1988 opened this issue May 28, 2024 · 10 comments
Closed
3 tasks done

Update and add translations #221

sander1988 opened this issue May 28, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@sander1988
Copy link
Owner

sander1988 commented May 28, 2024

We should update translations due to new functionality and we can add some more languages (when by provided). There was already some discussing in PR #216.

  • Update DE - Config and indego_alert items missing
  • Update PL - Config and indego_alert items missing
  • Add FR translations
@sander1988 sander1988 added the enhancement New feature or request label May 28, 2024
@sander1988 sander1988 self-assigned this May 28, 2024
@zmechu
Copy link

zmechu commented May 28, 2024

pl.json
PL translation

@sander1988
Copy link
Owner Author

@zmechu - Thank you for your contribution. The file doesn't seem to match the latest format (please see the EN file). Can you check and update your translation?

@zmechu
Copy link

zmechu commented May 28, 2024

pl.json
Should be OK now :-) Please check if it fit.

@kimzeuner
Copy link
Contributor

kimzeuner commented May 29, 2024

@zmechu i think you forgot the translations for the alert entity/attributes

    "entity": {
        "binary_sensor": {
            "indego_alert": {
                "state_attributes": {
                    "alerts_count": {
                        "name": "Number of alerts"
                    },
                    "last_alert_error_code": {
                        "name": "Error code (most recent)"
                    },
                    "last_alert_message": {
                        "name": "Alert message (most recent)"
                    },
                    "last_alert_date": {
                        "name": " Alert date (most recent)"
                    },
                    "last_alert_read": {
                        "name": "Alert status (most recent)",
                        "state": {
                            "read": "Read",
                            "unread": "Unread"
                        }
                    }
                }
            }
        }
    },

Here is the updated DE translation
de.json

What do you think of also translating the mower state and mower state detail ?
i'm using it in my system but i'm not sure if it is interesting for everyone ?!

@urbatecte
Copy link

@sander1988
Hi there !
Please find the french translation.
fr.json

Thanks for all your work 👌

@zmechu
Copy link

zmechu commented May 29, 2024

@zmechu i think you forgot the translations for the alert entity/attributes
Ups :-) I think use not up-to-date file. Please give me link to english file to translate,

@kimzeuner
Copy link
Contributor

This is the latest en.json file Link

@zmechu
Copy link

zmechu commented May 29, 2024

This is the latest en.json file Link

pl.json
now should be OK :-)

@obi134
Copy link
Contributor

obi134 commented May 29, 2024

Hi @sander1988 ,
Thank you for your effords. Please check following PR #222
Best regards

@sander1988
Copy link
Owner Author

Thank you everyone for your contribution! It has been merged and is available at the develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants