Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Add header to the queries & mutation #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nidbhardwaj
Copy link
Collaborator

@nidbhardwaj nidbhardwaj commented Feb 9, 2023

Description

Fixes # (issue)
The headers were not populated to the request.
Please use the below command to run create the collection -
deno run --allow-net --unsafely-ignore-certificate-errors src/cli.ts --auth=e23c675d272f988acb3447d448a46f81 https://wholesome-dimsum.myshopify.com/api/graphql

Please use your own token and shop URL.

Checklist:

  • I have performed a self-review of my own code
  • I have ran deno task ci to ensure that my code is formatted and linted.
  • I have linked the related issue (if there is no related issue please
    create one)
  • I have added tests if applicable (needs tests to be ready)

Copy link

@postmodem postmodem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment in our channel, but this would set the value we use for auth for running the CLI as the value in the generated request headers, right? We don't want that. Instead have it use value that is an env variable, and we can have something in the generated README that specifies what env variable they need to set in Insomnia, etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants