-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the Simblee-Board #211
base: master
Are you sure you want to change the base?
Conversation
Will commit actual code later today
So basically what is still a bit confusing to me is the nRF51822.cpp file. |
The reason I am asking this stuff is, the ANCS Example runs and I see the Device using my iphone, but when the iphone Messagebox wether I want to pair the devices and I klick yes, the device disconnects and crashes? Here is a log I created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this!
I don't have a Simblee board for various reason. So, would require a commitment on your side to "support" Simblee users if this is merged.
@@ -1,12 +1,21 @@ | |||
// Copyright (c) Sandeep Mistry. All rights reserved. | |||
// Licensed under the MIT license. See LICENSE file in the project root for full license information. | |||
|
|||
#if defined(NRF51) || defined(NRF52) || defined(__RFduino__) | |||
#ifdef __Simblee__ // TODO: Is this actually correct? It's the only way this file compiles for me using the S110 V8 headers. | |||
#define NRF5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I'd recommend this, better to add the equivalents in future down in the file. In case the nRF5 core updates the S110 version.
@@ -520,6 +529,8 @@ void nRF51822::begin(unsigned char advertisementDataSize, | |||
|
|||
#ifdef __RFduino__ | |||
RFduinoBLE_enabled = 1; | |||
#elif defined(__Simblee__) | |||
SimbleeBLE_enabled = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
Could be cause be incorrect soft device headers or BLE bond store things failing or corrupting flash page. Do the non-bonding/pairing related examples work? |
I made several tests with different S110 Headers and finally when using the S110 V8 Headers it did not only compile but also tests ran successfully on the Simblee.
It is tested with a Simblee running the ANCS-Example.
I still have a few questions about the changes in nRF51822.cpp and will ask them in the following days.
(See defines at the top of the File)