Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Simblee-Board #211

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add support for the Simblee-Board #211

wants to merge 3 commits into from

Conversation

PaulBrandt
Copy link

@PaulBrandt PaulBrandt commented Feb 2, 2018

I made several tests with different S110 Headers and finally when using the S110 V8 Headers it did not only compile but also tests ran successfully on the Simblee.
It is tested with a Simblee running the ANCS-Example.
I still have a few questions about the changes in nRF51822.cpp and will ask them in the following days.
(See defines at the top of the File)

@PaulBrandt
Copy link
Author

So basically what is still a bit confusing to me is the nRF51822.cpp file.
In order to make everything compile with the S110 V8 Headers I had to use the following defines:
#define NRF5 #define S110
Is this and the effects this causes actually correct?

@PaulBrandt
Copy link
Author

The reason I am asking this stuff is, the ANCS Example runs and I see the Device using my iphone, but when the iphone Messagebox wether I want to pair the devices and I klick yes, the device disconnects and crashes?

Here is a log I created.
version = 7 89 100
Start advertisement
BLE Peripheral - ANCS
Evt Connected 65:50:9c:d0:a7:0a
Connected event, central: 65:50:9c:d0:a7:0a
Evt Prim Srvc Disc Rsp 0x0
Evt Prim Srvc Disc Rsp 0x0
Evt Prim Srvc Disc Rsp 0x0
Evt Prim Srvc Disc Rsp 0x0
Evt Prim Srvc Disc Rsp 0x0
Evt Prim Srvc Disc Rsp 0x0
Evt Prim Srvc Disc Rsp 0x10A
Evt Write, handle = 11
02 00
Evt Char Disc Rsp 0x0
Evt Char Disc Rsp 0x0
Evt Char Disc Rsp 0x0
Evt Char Disc Rsp 0x10A
Remote services discovered event, central: 65:50:9c:d0:a7:0a
Evt Write Rsp 0x105
41
Evt Sec Params Request 1 0 4 0 0 16
[This is the moment where the iphone asks about pairing. Next line (Evt) shows when I click yes. Nothing happens afterwards]
Evt

Copy link
Owner

@sandeepmistry sandeepmistry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this!

I don't have a Simblee board for various reason. So, would require a commitment on your side to "support" Simblee users if this is merged.

@@ -1,12 +1,21 @@
// Copyright (c) Sandeep Mistry. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

#if defined(NRF51) || defined(NRF52) || defined(__RFduino__)
#ifdef __Simblee__ // TODO: Is this actually correct? It's the only way this file compiles for me using the S110 V8 headers.
#define NRF5
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I'd recommend this, better to add the equivalents in future down in the file. In case the nRF5 core updates the S110 version.

@@ -520,6 +529,8 @@ void nRF51822::begin(unsigned char advertisementDataSize,

#ifdef __RFduino__
RFduinoBLE_enabled = 1;
#elif defined(__Simblee__)
SimbleeBLE_enabled = 1;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

@sandeepmistry
Copy link
Owner

The reason I am asking this stuff is, the ANCS Example runs and I see the Device using my iphone, but when the iphone Messagebox wether I want to pair the devices and I klick yes, the device disconnects and crashes?

Could be cause be incorrect soft device headers or BLE bond store things failing or corrupting flash page. Do the non-bonding/pairing related examples work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants