allow advertising updates at runtime #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@floe thanks for submitting, I'll leave this open for now. I'd like to ensure it's doable and compatible on nRF8001 as well. |
|
OK, thanks. I don't have access to an nRF8001 at the moment, and the code looks quite ... involved ;-), so I'll leave this as-is at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a usecase where I want to update the advertisement data while the system is running. A hacky solution is to simply call
begin()again, but that essentially resets the SoC and also leaks memory. I've refactored the advertisement code so it can be called independently usingstartAdvertising().Best, Florian