Fuzzing Vulnerability Fixes #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Fuzz testing of VulCAN, it was discovered that both VatiCAN and LeiA exhibited bugs that allowed an unauthenticated user to adjust the RPM LEDs at will on the demo bench.
The LEDs would respond with "GOOD" and an RPM value calculated from the unauthenticated message.
The bugs occurred when performing moderate flooding with extended CAN ID packets.
Extended CAN ID packets were/are broadcast on ID 0x0, which meant that they caused garbled authenticated packets but also arrived on the right component due to being broadcast.
The following fixes patch some of that behavior.
They cause these garbled packets to be outright rejected instead of being accepted and causing an LED adjustment.