test: use curried Z functions more broadly #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safareli
reviewed
Jan 21, 2017
| @@ -15,21 +15,21 @@ module.exports = function(equals, A) { | |||
| identity: function(v) { | |||
| var lhs = ap(pure(id))(v); | |||
| var rhs = v; | |||
| return equals(lhs, rhs); | |||
| return equals(lhs)(rhs); | |||
There was a problem hiding this comment.
So with this changes API of "laws", from taking equals in uncurried form to curried form. rest of API is in uncurried form, which could be confusing (in case we move it to FL, but i think it's ok for now).
There was a problem hiding this comment.
Good point. Let's cross that bridge when we get to it.
safareli
approved these changes
Jan 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivating example:
ComposeFG.prototype[FL.ap] = function(other) { - return ComposeFG(Z.ap(Z.map(function(u) { return function(y) { return Z.ap(u, y); }; }, other.value), this.value)); + return ComposeFG(ap(map(ap)(other.value))(this.value)); };