either: add S.eitherToMaybe #215
Conversation
| //# maybeToEither :: a -> Maybe b -> Either a b | ||
| //. | ||
| //. Takes a value of any type and a Maybe, and returns an Either. | ||
| //. If the second argument is a Nothing, a Left containing the first |
There was a problem hiding this comment.
Might not be worth it for the sake of consistency throughout the docs, but when the types of arguments are different, it is easier for me to follow if the type is referenced rather than the argument position, ie
If the Maybe is a Nothing, a Left containing the first argument is returned.
Obviously since is a Nothing immediately follows second argument, I should know it is a Maybe I'm dealing with, but when I hit "second argument" I always pause.. think "second argument..??" jump back to the signature.. then continue on :)
There was a problem hiding this comment.
"The Maybe" is slightly less precise than "the second argument", since the first argument could also be a Maybe, but I'm happy to make your suggested change.
There was a problem hiding this comment.
Another possibility:
Converts a Maybe to an Either. A Nothing becomes a Left (containing the first argument); a Just becomes a Right.
What do you think?
davidchambers
force-pushed
the
dc-either
branch
2 times, most recently
from
c66ba2a to
57440b3
Compare
Closes #203