array: add S.prepend #205
Merged
array: add S.prepend #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchambers
force-pushed
the
dc-prepend
branch
2 times, most recently
from
eda1ff5 to
72466d6
Compare
|
How does this look, @gilligan? |
|
👍 looks good to me :) |
| }); | ||
|
|
||
| it('type checks its arguments', function() { | ||
| throws(function() { S.prepend('a', 'bc'); }, |
There was a problem hiding this comment.
Could we test the type checking of the final argument by adding a test that uses the placeholder as the first arg?
There was a problem hiding this comment.
What do you have in mind, Stefano? We test these failures:
prepend :: a -> Array a -> Array a
^^^^^^^
prepend :: a -> Array a -> Array a
^ ^
We don't test these failures:
prepend :: a -> Array a -> Array a
^^^^^^^
prepend :: a -> Array a -> Array a
^ ^
Assuming our function is implemented correctly, there's no way to test invalid return values. ;)
There was a problem hiding this comment.
Don't mind me, I'm losing my mind, I completely misread the first test there.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #197