number, string: add S.min and S.max #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| type === 'String'; | ||
| } | ||
| ); | ||
|
|
There was a problem hiding this comment.
We should document all the type classes at some point.
There was a problem hiding this comment.
Agreed. This will also be a very useful type.
davidchambers
force-pushed
the
dc-min-max
branch
from
bfc14ca to
3aad29a
Compare
|
Prompted by your comment, @svozza, I added several more assertions. I also updated the examples to highlight the difference between number comparison and string comparison, and added a paragraph to each function's description to explain the distinction. |
|
LGTM. |
davidchambers
added a commit
that referenced
this pull request
Feb 8, 2016
number, string: add S.min and S.max
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R.minandR.max, but with type checking. I want to tick some boxes in #145. :)