Feedback round 1

* Rename parameter from "json" to "s" * Lowecase "Type" * Proper JSON without the spaces
sanctuary-js · Mar 24, 2016 · d61b9c3 · d61b9c3
1 parent 0c2b24a
commit d61b9c3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/index.js b/index.js
@@ -2764,7 +2764,7 @@
   def('parseJson',
       {},
       [TypeRep, $.String, $Maybe(a)],
-      function(type, json) { return filter(is(type), encase(JSON.parse, json)); });
+      function(type, s) { return filter(is(type), encase(JSON.parse, s)); });
 
   //. ### RegExp
 

diff --git a/test/index.js b/test/index.js
@@ -4149,8 +4149,8 @@ describe('parse', function() {
       eq(S.parseJson(Object, '[Invalid JSON]'), S.Nothing());
     });
 
-    it('returns a Nothing when the parsed result is not a member of the given Type', function() {
-      eq(S.parseJson(Array, '{"foo": "bar"}'), S.Nothing());
+    it('returns a Nothing when the parsed result is not a member of the given type', function() {
+      eq(S.parseJson(Array, '{"foo":"bar"}'), S.Nothing());
     });
 
   });