Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safareli
approved these changes
Jan 1, 2017
| @@ -76,7 +76,7 @@ List.prototype[FL.reduce] = function(f, x) { | |||
| List.prototype[FL.traverse] = function(f, of) { | |||
| return this.tag === 'Nil' ? | |||
| of(Nil) : | |||
| Z.ap(Z.map(curry2(Cons), f(this.head)), Z.traverse(of, f, this.tail)); | |||
| Z.ap(Z.map(curry2(Cons), f(this.head)), this.tail[FL.traverse](f, of)); | |||
There was a problem hiding this comment.
This part was a bit confusing, why not call Z.traverse(List, f, this.tail)?
There was a problem hiding this comment.
of is not necessarily List['fantasy-land/of'] (in fact, it almost certainly is not). We have no way of getting from of to a type representative, so we're forced to use the of-based API rather than our API based on type representatives.
If we update fantasy-land/traverse to take a type representative this problem will disappear. ;)
There was a problem hiding this comment.
davidchambers
changed the title
|
⭐️ |
davidchambers
force-pushed
the
dc-traverse-sequence
branch
2 times, most recently
from
95c54d8 to
66e1402
Compare
safareli
approved these changes
Jan 18, 2017
davidchambers
force-pushed
the
dc-traverse-sequence
branch
from
b8e5cf8 to
aa6f7af
Compare
davidchambers
force-pushed
the
dc-traverse-sequence
branch
from
aa6f7af to
332c42f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change, but a nice change I think. Do you agree?