provide a placeholder value #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
safareli
reviewed
Sep 27, 2016
| [9]: http://ramdajs.com/docs/#toString | ||
| [10]: https://en.wikipedia.org/wiki/Semigroup | ||
| [11]: https://github.com/fantasyland/fantasy-land#semigroup | ||
| [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/arguments |
There was a problem hiding this comment.
Maybe change them to some non number (NaN :D) values so we don't need to update all of them when one link is removed/added, as in sanctuary-type-classes
There was a problem hiding this comment.
Good idea. I'll do so now in a separate pull request.
There was a problem hiding this comment.
I rebased this branch after merging #84. The changes to README.md are much clearer now. Would you mind having another look?
davidchambers
force-pushed
the
dc-placeholder
branch
from
d18df6e to
8b890b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With sanctuary-js/sanctuary#216, Sanctuary is becoming more an alternative to Ramda rather than a complement. It doesn't make sense to continue to rely on Ramda to provide the placeholder value. I found myself defining
S.__but then realized that the placeholder should be defined here since it is sanctuary-def which actually makes use of it. It's probably still a good idea to defineS.__, but we can simply make it an 👽 once$.__is defined.