make type checking optional #28
Conversation
|
|
||
| The first argument to `$.create` determines whether type checking is enabled. | ||
| One may elect to pay the performance cost of run-time type checking only during | ||
| development. For example: |
There was a problem hiding this comment.
It's possible to misread the second sentence:
Only during development may one elect to pay the performance cost of run-time type checking.
💯 points to the first person to suggest an unambiguous alternative. :)
There was a problem hiding this comment.
How about:
This allows one to only pay the performance cost of run-time type type checking during development.
There was a problem hiding this comment.
💯 points for Stefano!
davidchambers
force-pushed
the
dc-optional-type-checking
branch
from
399a442 to
3577169
Compare
| The first argument to `$.create` determines whether type checking is enabled. | ||
| This allows one to only pay the performance cost of run-time type checking | ||
| during development. For example: | ||
|
|
There was a problem hiding this comment.
Great to make this an argument rather than env var or an arbitrary check.
There was a problem hiding this comment.
Yep. I want to stay out of the application configuration game. :)
|
@davidchambers Should we add some sort of CI to automatically run tests on PRs? |
We're using CircleCI. |
Sorry, missed that -- thought the "1 successful check" was referring to merge conflicts. |
davidchambers
force-pushed
the
dc-optional-type-checking
branch
from
3577169 to
e196bc1
Compare
make type checking optional
Closes #6
I'm not fond of Boolean flags, but
{ checkTypes :: Boolean }would introduce a separate problem: one could provide an invalid value such as{typeCheck: true}. I'd prefer to avoid having to name the option.When viewing the changes, run
location.search = '?w='in your console for best results. ;)