remove apply thumbnail to manifest and fix specs #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kirkkwang
deleted the
remove-apply-thumbnail-to-manifest-from-record-property-builder
branch
kirkkwang
restored the
remove-apply-thumbnail-to-manifest-from-record-property-builder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cjcolvar This is my attempt to remove
apply_thumbnail_to(manifest). It definitely turned out more hairy than I thought. I couldn't manage to find a way to test it either without investing a lot more time into it. This changed a lot of files so I'm not fully convinced it worth it. Let me know what you think, or if there's a better way 😅